From 954edbbe933dfd2f66ae68119d647c406bce1a3b Mon Sep 17 00:00:00 2001
From: Giancarlo Colaci <giancarlo.colaci@mail.polimi.it>
Date: Fri, 3 Feb 2017 16:02:38 +0100
Subject: [PATCH] Finita la modifica delle tabelle

---
 5.Code Inspection/CodeInspection.lyx | 267 ++++++++++++++++++---------
 1 file changed, 182 insertions(+), 85 deletions(-)

diff --git a/5.Code Inspection/CodeInspection.lyx b/5.Code Inspection/CodeInspection.lyx
index e310394..9d8c5e2 100644
--- a/5.Code Inspection/CodeInspection.lyx	
+++ b/5.Code Inspection/CodeInspection.lyx	
@@ -2348,7 +2348,8 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+In order to respect the correct order the class implementation comment should
+ follow the class statement
 \end_layout
 
 \end_inset
@@ -2357,7 +2358,8 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+In order to respect the correct order the class implementation comment should
+ follow the class statement
 \end_layout
 
 \end_inset
@@ -2366,7 +2368,8 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+In order to respect the correct order the class implementation comment should
+ follow the class statement
 \end_layout
 
 \end_inset
@@ -2388,7 +2391,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+None
 \end_layout
 
 \end_inset
@@ -2397,7 +2400,7 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+None
 \end_layout
 
 \end_inset
@@ -2406,7 +2409,7 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+None
 \end_layout
 
 \end_inset
@@ -2428,7 +2431,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -2437,7 +2440,11 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+L71: The method 
+\shape italic
+GetWriter
+\shape default
+ returns an encapsulated object, not previously defined 
 \end_layout
 
 \end_inset
@@ -2446,7 +2453,11 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+L71: The method 
+\shape italic
+GetWriter
+\shape default
+ returns an encapsulated object, not previously defined
 \end_layout
 
 \end_inset
@@ -2556,7 +2567,7 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+None
 \end_layout
 
 \end_inset
@@ -2565,7 +2576,7 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -2574,7 +2585,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -2596,7 +2607,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+None
 \end_layout
 
 \end_inset
@@ -2605,7 +2616,7 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+None
 \end_layout
 
 \end_inset
@@ -2614,7 +2625,7 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+None
 \end_layout
 
 \end_inset
@@ -2636,7 +2647,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -2645,7 +2656,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+None
 \end_layout
 
 \end_inset
@@ -2654,7 +2665,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+None
 \end_layout
 
 \end_inset
@@ -2676,7 +2687,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2685,7 +2696,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2694,7 +2705,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2716,7 +2727,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2725,7 +2736,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2734,7 +2745,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -2756,7 +2767,39 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
+L129: The declaration 
+\shape italic
+Writer outWriter = new StringWriter();
+\shape default
+ should be put in the try-catch instruction before the if condition at line
+ 126;
+\end_layout
 
+\begin_layout Plain Layout
+L131: The declaration 
+\shape italic
+String outString = outWriter.toString();
+\shape default
+ should be put in the try-catch instruction before the if condition at line
+ 126;
+\end_layout
+
+\begin_layout Plain Layout
+L184: The declaration 
+\shape italic
+String candidateFieldName = ModelUtil.dbNameToVarName(confItemContentTypeId);
+\shape default
+ should be put right after the method getProductConfigItemContentAsText
+ definition at line 156;
+\end_layout
+
+\begin_layout Plain Layout
+L185: The declaration 
+\shape italic
+ModelEntity productConfigItemModel = delegator.getModelEntity("ProductConfigItem"
+);
+\shape default
+ should be put right after the if condition at line 161;
 \end_layout
 
 \end_inset
@@ -2765,7 +2808,11 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+L102: The declaration
+\shape italic
+ RequestHandler rh = (RequestHandler) ctx.getAttribute("_REQUEST_HANDLER_");
+\shape default
+ should be put right after the ServletContext ctx declaration at line 89;
 \end_layout
 
 \end_inset
@@ -2774,7 +2821,11 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+L102: The declaration
+\shape italic
+ RequestHandler rh = (RequestHandler) ctx.getAttribute("_REQUEST_HANDLER_");
+\shape default
+ should be put right after the ServletContext ctx declaration at line 89;
 \end_layout
 
 \end_inset
@@ -2884,7 +2935,7 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+None
 \end_layout
 
 \end_inset
@@ -2893,7 +2944,7 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -2902,7 +2953,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -2924,7 +2975,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+None
 \end_layout
 
 \end_inset
@@ -2933,7 +2984,7 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+None
 \end_layout
 
 \end_inset
@@ -2942,7 +2993,7 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+None
 \end_layout
 
 \end_inset
@@ -2964,7 +3015,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -2973,7 +3024,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+None
 \end_layout
 
 \end_inset
@@ -2982,7 +3033,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+None
 \end_layout
 
 \end_inset
@@ -3092,7 +3143,7 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+None
 \end_layout
 
 \end_inset
@@ -3101,7 +3152,7 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3110,7 +3161,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3132,7 +3183,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+None
 \end_layout
 
 \end_inset
@@ -3141,7 +3192,7 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+None
 \end_layout
 
 \end_inset
@@ -3150,7 +3201,7 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+None
 \end_layout
 
 \end_inset
@@ -3172,7 +3223,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -3181,7 +3232,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+None
 \end_layout
 
 \end_inset
@@ -3190,7 +3241,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+None
 \end_layout
 
 \end_inset
@@ -3428,7 +3479,7 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+None
 \end_layout
 
 \end_inset
@@ -3437,7 +3488,7 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3446,7 +3497,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3468,7 +3519,8 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+Every error message just notifies the error without providing any guidance
+ to solve the issue 
 \end_layout
 
 \end_inset
@@ -3477,7 +3529,8 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+Every error message just notifies the error without providing any guidance
+ to solve the issue
 \end_layout
 
 \end_inset
@@ -3486,7 +3539,8 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+Every error message just notifies the error without providing any guidance
+ to solve the issue
 \end_layout
 
 \end_inset
@@ -3508,7 +3562,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -3517,7 +3571,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+None
 \end_layout
 
 \end_inset
@@ -3526,7 +3580,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+None
 \end_layout
 
 \end_inset
@@ -3561,7 +3615,7 @@ Output Format
 \begin_inset Float table
 wide false
 sideways false
-status collapsed
+status open
 
 \begin_layout Plain Layout
 \begin_inset Tabular
@@ -3636,7 +3690,7 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+None
 \end_layout
 
 \end_inset
@@ -3645,7 +3699,7 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3654,7 +3708,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+None
 \end_layout
 
 \end_inset
@@ -3676,7 +3730,7 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+None
 \end_layout
 
 \end_inset
@@ -3685,7 +3739,7 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+None
 \end_layout
 
 \end_inset
@@ -3694,7 +3748,7 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+None
 \end_layout
 
 \end_inset
@@ -3716,7 +3770,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.22
+None
 \end_layout
 
 \end_inset
@@ -3725,7 +3779,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.09
+None
 \end_layout
 
 \end_inset
@@ -3734,7 +3788,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-1.00
+None
 \end_layout
 
 \end_inset
@@ -3756,7 +3810,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3765,7 +3819,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3774,7 +3828,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3796,7 +3850,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3805,7 +3859,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3814,7 +3868,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3836,7 +3890,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3845,7 +3899,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3854,7 +3908,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3876,7 +3930,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3885,7 +3939,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3894,7 +3948,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None
 \end_layout
 
 \end_inset
@@ -3916,7 +3970,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None (explicit casts)
 \end_layout
 
 \end_inset
@@ -3925,7 +3979,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None (explicit casts)
 \end_layout
 
 \end_inset
@@ -3934,7 +3988,7 @@ Narrow band email
 \begin_inset Text
 
 \begin_layout Plain Layout
-
+None (explicit casts)
 \end_layout
 
 \end_inset
@@ -3969,7 +4023,7 @@ Computation, Comparisons and Assignments
 \begin_inset Float table
 wide false
 sideways false
-status collapsed
+status open
 
 \begin_layout Plain Layout
 \begin_inset Tabular
@@ -4044,7 +4098,23 @@ UrlRegexpTransform
 \begin_inset Text
 
 \begin_layout Plain Layout
-International
+L141: Just a GeneralException is caught;
+\end_layout
+
+\begin_layout Plain Layout
+L145: Just an IOException is caught;
+\end_layout
+
+\begin_layout Plain Layout
+L151: Just GeneralException and IOException are caught;
+\end_layout
+
+\begin_layout Plain Layout
+L156: Just GeneralException and IOException are caught;
+\end_layout
+
+\begin_layout Plain Layout
+Not all the possible relevant exceptions are caught 
 \end_layout
 
 \end_inset
@@ -4053,7 +4123,19 @@ International
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+L77: Just an IOException is caught;
+\end_layout
+
+\begin_layout Plain Layout
+L81: Just an IOException is caught; 
+\end_layout
+
+\begin_layout Plain Layout
+L121: Just an Exception is caught;
+\end_layout
+
+\begin_layout Plain Layout
+Not all the possible relevant exceptions are caught 
 \end_layout
 
 \end_inset
@@ -4062,7 +4144,19 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Multi-city and multi-company
+L77: Just an IOException is caught;
+\end_layout
+
+\begin_layout Plain Layout
+L81: Just an IOException is caught; 
+\end_layout
+
+\begin_layout Plain Layout
+L121: Just an Exception is caught;
+\end_layout
+
+\begin_layout Plain Layout
+Not all the possible relevant exceptions are caught 
 \end_layout
 
 \end_inset
@@ -4084,7 +4178,8 @@ Multi-city and multi-company
 \begin_inset Text
 
 \begin_layout Plain Layout
-Some phone, mail
+For all the exceptions written above, the developers only provide a message
+ without an appropriate action to solve the error
 \end_layout
 
 \end_inset
@@ -4093,7 +4188,8 @@ Some phone, mail
 \begin_inset Text
 
 \begin_layout Plain Layout
-Individual phone, fax
+For all the exceptions written above, the developers only provide a message
+ without an appropriate action to solve the error
 \end_layout
 
 \end_inset
@@ -4102,7 +4198,8 @@ Individual phone, fax
 \begin_inset Text
 
 \begin_layout Plain Layout
-Narrow band email
+For all the exceptions written above, the developers only provide a message
+ without an appropriate action to solve the error
 \end_layout
 
 \end_inset